Skip to content

Remove redundant action-aliases for pack install #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kami merged 1 commit into from
Jan 25, 2019
Merged

Remove redundant action-aliases for pack install #4512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ Changed

* Changed the ``inquiries`` API path from ``/exp`` to ``/api/v1`` #4495

Fixed
~~~~~

* Fixed the ``packs.pack_install`` / ``!pack install {{ packs }}`` action-alias to not have
redundant patterns. Previously this prevented it from being executed via
``st2 action-alias execute 'pack install xxx'``. #4511

Contributed by Nick Maludy (Encore Technologies)

2.10.0 - December 13, 2018
--------------------------

Expand Down
5 changes: 1 addition & 4 deletions contrib/packs/aliases/pack_install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ action_ref: "packs.install"
pack: "packs"
description: "Install/upgrade StackStorm packs."
formats:
- display: "pack install <pack>[,<pack>]"
representation:
- "pack install {{ packs }}"
- display: "pack install <gitUrl>[,<gitUrl>]"
- display: "pack install <pack_name|git_url>[,<pack_name|git_url>]"
representation:
- "pack install {{ packs }}"
ack:
Expand Down
6 changes: 3 additions & 3 deletions st2client/st2client/commands/action_alias.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ class ActionAliasMatchCommand(resource.ResourceCommand):
def __init__(self, resource, *args, **kwargs):
super(ActionAliasMatchCommand, self).__init__(
resource, 'match',
'Get the list of %s that match the command text.' %
resource.get_plural_display_name().lower(),
'Get the %s that match the command text.' %
resource.get_display_name().lower(),
*args, **kwargs)

self.parser.add_argument('match_text',
metavar='command',
help=('Get the list of %s that match the command text.' %
help=('Get the %s that match the command text.' %
resource.get_display_name().lower()))
self.parser.add_argument('-a', '--attr', nargs='+',
default=self.display_attributes,
Expand Down