Update pyyaml and flex contraints #4552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4dcoder
reviewed
Feb 16, 2019
requirements.txt
Outdated
| cryptography==2.4.2 | ||
| eventlet==0.24.1 | ||
| flex>=6.13.2,<6.15.0 | ||
| flex |
Contributor
There was a problem hiding this comment.
In your other PR at #4510, flex is pinned to flex>=6.13.2,<6.15.0. How come the version specific dependencies are gone?
Member
There was a problem hiding this comment.
We are missing an entry for flex in fixed-requirements.txt.
I will go ahead and add it.
requirements files.
Member
|
LGTM, thanks for adding new |
Kami
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update requirements files with updated PyYAML and flex constraints.
I also add a make target to run
make requirementsand check that it doesn't change any requirements files (eg: some files were changed but not checked into git), and integrated that into the Travis tests.H/T: @m4dcoder