-
-
Notifications
You must be signed in to change notification settings - Fork 782
[WIP] [DONT MERGE] Upgrade tooz, re-enable service registry registration by default #4608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
driver which includes support for group membership functionality which is needed for service registry functionaly.
|
It looks like group membership functionality is quite badly broken in those two drivers and will need more work. |
|
Tracking & cross-linking corresponding issue in |
| semver | ||
| six | ||
| # Need our fork with various bug fixes in etcd drivers | ||
| git+https://github.com/StackStorm/tooz.git@etcd3_driver_fixes#egg=tooz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per StackStorm/stackstorm-k8s#61 (review), looks like we'll also need etcd3gw pip dependency to make etcd3+http entrypoint (https://docs.openstack.org/tooz/latest/user/drivers.html#etcd3-gateway) work out of the box
|
Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue. |
|
Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue. |
This pull request updates tooz dependency to our fork - https://github.com/openstack/tooz/compare/master...StackStorm:etcd3_driver_fixes?expand=1.
Latest version does contain some group related functionality in
etcd3andetcd3+httpdriver, but it's partial and broken.I've fixed various issues in our fork and I also plan to submit changes upstream (but it might take a while to get them merged and new version releases) so we need to use our fork for now.
There are some more issues I need to fix there.
NOTE: For this to work in stackstorm-ha, we need to ensure etcd >= 3.0.0 is installed and used. In addition to that, we need to use
etcd+http://localhostdriver there.