Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Mar 21, 2019

This pull request updates tooz dependency to our fork - https://github.com/openstack/tooz/compare/master...StackStorm:etcd3_driver_fixes?expand=1.

Latest version does contain some group related functionality in etcd3 and etcd3+http driver, but it's partial and broken.

I've fixed various issues in our fork and I also plan to submit changes upstream (but it might take a while to get them merged and new version releases) so we need to use our fork for now.

There are some more issues I need to fix there.

NOTE: For this to work in stackstorm-ha, we need to ensure etcd >= 3.0.0 is installed and used. In addition to that, we need to use etcd+http://localhost driver there.

Kami added 2 commits March 21, 2019 20:42
driver which includes support for group membership functionality which is
needed for service registry functionaly.
@Kami Kami added this to the 3.0.0 milestone Mar 21, 2019
@Kami
Copy link
Member Author

Kami commented Mar 21, 2019

It looks like group membership functionality is quite badly broken in those two drivers and will need more work.

@Kami Kami changed the title [WIP] Upgrade tooz, re-enable service registry registration by default [WIP] [DONT MERGE] Upgrade tooz, re-enable service registry registration by default Mar 21, 2019
@arm4b
Copy link
Member

arm4b commented Mar 21, 2019

Tracking & cross-linking corresponding issue in stackstorm-ha for switching etcd2 -> etcd3: StackStorm/stackstorm-k8s#58. We'll try to migrate to v3 in next few days.

semver
six
# Need our fork with various bug fixes in etcd drivers
git+https://github.com/StackStorm/tooz.git@etcd3_driver_fixes#egg=tooz
Copy link
Member

@arm4b arm4b Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per StackStorm/stackstorm-k8s#61 (review), looks like we'll also need etcd3gw pip dependency to make etcd3+http entrypoint (https://docs.openstack.org/tooz/latest/user/drivers.html#etcd3-gateway) work out of the box

@Kami Kami removed this from the 3.0.0 milestone Apr 23, 2019
@stale
Copy link

stale bot commented Jul 22, 2019

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue.

@stale stale bot added the stale label Jul 22, 2019
@stale stale bot removed the stale label Apr 1, 2020
@stale
Copy link

stale bot commented Jul 1, 2020

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically marking is as stale. If this issue is not relevant or applicable anymore (problem has been fixed in a new version or similar), please close the issue or let us know so we can close it. On the contrary, if the issue is still relevant, there is nothing you need to do, but if you have any additional details or context which would help us when working on this issue, please include it as a comment to this issue.

@stale stale bot added the stale label Jul 1, 2020
@Kami Kami closed this Apr 17, 2021
@arm4b arm4b deleted the upgrade_tooz_etcd_driver branch January 6, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants