st2-self-check should ignore any pack actions which name doesn't start with "test_" #4622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
With StackStorm/st2tests#153 which fixes the root cause, this change is not technically needed anymore, but I don't think it hurts either and it's an additional safe guard. |
Member
Author
|
I noticed yet another "unrelated" self check issue which I fixed in bb8be32. We didn't skip winrm runner tests by default so self check would fail (same as other Windows runners, those tests don't work out of the box and shouldn't run by default). |
stdout and stderr data with \n when pty is used. When pty is used, default behavior is to replace all new line characters \n with \r\n which is almost never desired.
…o update_st2_self_check
…\r\n in the" This reverts commit 21fac2c.
Kami
commented
Apr 9, 2019
| continue | ||
| fi | ||
|
|
||
| if [ ${RUN_WINDOWS_TESTS} = "false" ] && [ ${TEST} = "tests.test_winrm_runners" ]; then |
Member
Author
There was a problem hiding this comment.
Just a heads up - that's something we missed while working on original WinRM runner PRs.
Those tests only works on servers which have access to a configured Windows host which is not the case for default StackStorm installation and st2-self-check script.
jinpingh
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes bug in
st2-self-checkinadvertently introduced in this PR - StackStorm/st2tests#150.It updates
st2-self-checkcode so it only tries to run actions which name starts withtest_.(Per my comment in the other PR, I assume we ended up with this bug / regression due to lack of understanding of the difference between various test repos and packs we have - we need better developer documentation on that).