Allow cancel to proceed if workflow execution is not found or completed #4736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the workflow execution cancelation to proceed even if the workflow execution is not found or completed otherwise the method will raise an exception and the workflow execution will be stuck with a canceling status.
jinpingh
approved these changes
Jul 9, 2019
contrib/runners/orquesta_runner/orquesta_runner/orquesta_runner.py
Outdated
Show resolved
Hide resolved
Instead of rethrowing the exception, capture and log the error and traceback, and return the error in the result. Then let the cancelation continue to process children and determine final status. If the exception is rethrown, the workflow execution will be stuck in a canceling status. Add unit test to cover this scenario.
m4dcoder
force-pushed
the
fix-orquesta-cancel
branch
from
f764c58 to
c9c2b3c
Compare
jinpingh
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the workflow execution cancelation to proceed even if the workflow execution is not found or completed otherwise the method will raise an exception and the workflow execution will be stuck with a canceling status. Fixes #4735