Fix st2 execution get not printing action ref #4741

nmaludy · 2019-07-12T15:03:03Z

Before:

$ st2 execution get 5d289e5f9387ef2ebde9513e
id: 5d289e5f9387ef2ebde9513e
status: succeeded (0s elapsed)
parameters: 
  cmd: date
result: 
  failed: false
  return_code: 0
  stderr: ''
  stdout: Fri Jul 12 10:51:11 EDT 2019
  succeeded: true

After:

$ st2 execution get 5d289e5f9387ef2ebde9513e
id: 5d289e5f9387ef2ebde9513e
action.ref: core.local
context.user: st2admin
parameters: 
  cmd: date
status: succeeded (0s elapsed)
start_timestamp: Fri, 12 Jul 2019 14:51:11 UTC
end_timestamp: Fri, 12 Jul 2019 14:51:11 UTC
result: 
  failed: false
  return_code: 0
  stderr: ''
  stdout: Fri Jul 12 10:51:11 EDT 2019
  succeeded: true

…ands

m4dcoder

Minor question about removing liveaction.

m4dcoder · 2019-07-20T00:20:19Z

st2client/st2client/commands/action.py

 class ActionExecutionGetCommand(ActionRunCommandMixin, ResourceViewCommand):
    display_attributes = ['id', 'action.ref', 'context.user', 'parameters', 'status',
-                          'start_timestamp', 'end_timestamp', 'result', 'liveaction']
+                          'start_timestamp', 'end_timestamp', 'result']


We don't want liveaction?

m4dcoder · 2019-07-20T00:22:46Z

Also, this change resulted in errors in various unit tests which didn't expect the extra fields. This is why the travis-ci/pr job failed. Please run make tests locally to ensure tests passed.

Kami · 2019-08-03T15:07:59Z

Thanks for contribution.

It would be great to add a test case for it to avoid such regressions in the future.

concurrency abstraction which works with either gevent or eventlet.

and supports logging config paths which are relative to st2.conf file directory.

the ProcessSensorContainer class.

script to a method which can be overriden in derived classes.

…es and ?exclude_attributes

?show_secrets=True for admins.

rules API endpoint.

This way we can troubleshoot various "fail to start" issues on CI. Without this change, we have no visibility if service fails to start before the actual service starts writting into it's own log file. Sadly we can't rely on new version of screen which supports -Logfile path.log flag so we need to use screen config per screen window so we can use different log files for different processes.

…_issue fixing subprocess to use system buffer instead of being unbuffered

…pter Don't call eventlet directly inside the st2reactor code

…ule-parameters /v1/rules API endpoint action parameters secrets masking (additional changes on top of StackStorm#4788)

gunicorn if auth.api_url config option was not set. NOTE: This issue would only affect deployments using gunicorn which don't have auth.api_url config option set.

…unicorn_issue Fix a bug with authentication API endpoint returning internal server error under gunicorn if auth.api_url config option was not set

…maludy/st2 into bugfix/4739-st2-cli-action-ref

Kami

I verified this works as expected so I will go ahead and merge this into master.

I believe "liveaction" attribute was removed since Nick changed the code to use display_attributes defined on the class and we don't want to include "liveaction" object in st2 execution run and st2 execution get command output.

Thanks again for the contribution.

files.

Fixed StackStorm#4739. st2 cli now prints action ref for various comm…

7f8a651

…ands

arm4b requested review from Kami and m4dcoder July 16, 2019 12:33

m4dcoder reviewed Jul 20, 2019

View reviewed changes

Kami added bug CLI component:st2client labels Aug 3, 2019

jeansfelix and others added 18 commits September 12, 2019 11:54

Fix the visibility of action secret parameters on rule

cfe0aa7

Fix PEP8

0f1bae2

Merge branch 'master' into fix/mask-secrets-rule-parameters

c604c15

Add ActionResourceManager and implement GET entrypoint

1e8aa64

Instead of calling eventlet directly, pass the calls through the

d05c236

concurrency abstraction which works with either gevent or eventlet.

Add missing change.

ee52f63

Add a missing import.

b1360e6

Add missing function to __all__.

e8e8e49

Also update test code in st2reactor to utilize our concurrency wrapper.

1b343ee

Update st2common.log.setup function so it takes new "st2_config_path"

6478e3d

and supports logging config paths which are relative to st2.conf file directory.

Allow user to pass "wrapper_script_path" and "create_token" arguments to

b5780b8

the ProcessSensorContainer class.

Move code for setting CLI arguments which are passed to the wrapper

cebeccc

script to a method which can be overriden in derived classes.

Update CHANGELOG to reflect new feature

eaa0076

Add unit tests for the new ActionResourceManager methods

fcf6fe0

Assert correctness of return value and add 404 test

622fbfc

Use assertRaisesRegexp

150aafe

Merge branch 'master' into trstruth/entrypoint

6a86330

Merge branch 'master' into bugfix/4739-st2-cli-action-ref

3a70c59

Kami added this to the 3.1.1 milestone Oct 9, 2019

arm4b removed this from the 3.1.1 milestone Oct 10, 2019

Add tests when secrets masking works correctly when ?include_attribut…

4f7f7a1

…es and ?exclude_attributes

Kami added 20 commits October 29, 2019 19:23

get one and get all rules api endpoint show also support

70f960b

?show_secrets=True for admins.

Add some test cases which verify secrets masking works correctly for

3400a76

rules API endpoint.

Fix lint, add missing change.

0343096

Re-generate sample config.

e7d62d1

Use a separate action for bufsize test case.

e446a46

Add some log messages to make it easier to identify output.

b3d885a

Merge pull request StackStorm#4803 from jdmeyer3/bug/thread_buffering…

28d7c50

…_issue fixing subprocess to use system buffer instead of being unbuffered

Merge branch 'master' into fix/mask-secrets-rule-parameters

3dc9ca1

Remove unused method, fix docstring.

bfafd43

Add additional clarification.

ec6b7fd

Merge branch 'master' into reactor_gevent_adapter

dc178a9

Merge pull request StackStorm#4792 from StackStorm/reactor_gevent_ada…

92c7271

…pter Don't call eventlet directly inside the st2reactor code

Merge branch 'master' into fix/mask-secrets-rule-parameters

1022c1e

Update changelog.

06628a7

Merge pull request StackStorm#4807 from StackStorm/fix/mask-secrets-r…

7ecb5fe

…ule-parameters /v1/rules API endpoint action parameters secrets masking (additional changes on top of StackStorm#4788)

Fix a bug with authentication returning internal server error under

0fde265

gunicorn if auth.api_url config option was not set. NOTE: This issue would only affect deployments using gunicorn which don't have auth.api_url config option set.

Add changelog entry.

b8b874f

Merge pull request StackStorm#4809 from StackStorm/fix_api_url_none_g…

3ce8ef9

…unicorn_issue Fix a bug with authentication API endpoint returning internal server error under gunicorn if auth.api_url config option was not set

Merge branch 'bugfix/4739-st2-cli-action-ref' of https://github.com/n…

deb7c1b

…maludy/st2 into bugfix/4739-st2-cli-action-ref

Kami approved these changes Nov 1, 2019

View reviewed changes

Kami added this to the 3.2.0 milestone Nov 1, 2019

Kami self-assigned this Nov 1, 2019

Kami added 4 commits November 1, 2019 21:32

Update affected tests.

03909b4

Update changelog.

32446df

Fix test so it also passes with another common content type for python

5d3a3a8

files.

Update more affected tests.

1d1aa02

Kami merged commit 1a5dc9b into StackStorm:master Nov 1, 2019

blag added v3.1.1 labels Feb 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix st2 execution get not printing action ref #4741

Fix st2 execution get not printing action ref #4741

Uh oh!

nmaludy commented Jul 12, 2019

Uh oh!

m4dcoder left a comment

Uh oh!

m4dcoder Jul 20, 2019

Uh oh!

m4dcoder commented Jul 20, 2019

Uh oh!

Kami commented Aug 3, 2019

Uh oh!

Kami left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Fix st2 execution get not printing action ref #4741

Fix st2 execution get not printing action ref #4741

Uh oh!

Conversation

nmaludy commented Jul 12, 2019

Uh oh!

m4dcoder left a comment

Choose a reason for hiding this comment

Uh oh!

m4dcoder Jul 20, 2019

Choose a reason for hiding this comment

Uh oh!

m4dcoder commented Jul 20, 2019

Uh oh!

Kami commented Aug 3, 2019

Uh oh!

Kami left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants