Fix rbac execution_view unable to verify the pack or uid (v3.1) #4766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
works when RBAC is enabled. When RBAC is enabled, we simply use admin use when testing include and exclude attributes functionality.
Kami
approved these changes
Aug 14, 2019
Member
|
Next time inside the PR description please also reference the original PR from which you are cherry picking the changes. And also make it clear in the PR title that's targeted for the v3.1 branch. |
m4dcoder
changed the title
Contributor
Author
|
@Kami Updated title and description. Thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rbac with execution view where the rbac is unable to verify the pack or uid of the execution because it was not returned from the action execution db. This would result in an internal server error when trying to view the results of a single execution. This fix is cherry picked from selected commits at PR #4759.