Convert escaped dict fields in workflow db models to dict fields #4854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
m4dcoder
force-pushed
the
fix-wf-db-models
branch
from
cbdff8e to
8824561
Compare
arm4b
approved these changes
Feb 8, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
LGTM
Left one minor improvement comment.
| before returning error to the end user. #4834 | ||
| * Upgrade ``pymongo`` to the latest stable version (``3.10.0.``). #4835 (improvement) | ||
| * Remove `.scrutinizer.yml` config file. No longer used. | ||
| * Convert escaped dict and dynamic fields in workflow db models to normal dict and dynamic fields. |
Member
There was a problem hiding this comment.
Please include a note that it's performance optimization, which is not clear from the current changelog description.
IMO it's important to communicate perf. enhancements explicitly as they're really "high valued" improvements our users will be happy to find.
To improve database performance, convert stormbase.EscapedDictField to mongoengine.DictField and stormbase.EscapedDynamicField to mongoengine.DynamicField in workflow and task execution DB models. An escaped field requires additional step to read from and write to the database.
m4dcoder
force-pushed
the
fix-wf-db-models
branch
from
8824561 to
5a1cd91
Compare
This was referenced Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve database performance, convert stormbase.EscapedDictField to mongoengine.DictField and stormbase.EscapedDynamicField to mongoengine.DynamicField in workflow and task execution DB models. An escaped field requires additional step to read from and write to the database.