Add changelog entries for #4869 #4871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
Merged
blag
suggested changes
Feb 20, 2020
Contributor
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
I don't think you need to justify the changes in the changelog, you just need to document what you did. Here's the previous changelog entry for updating requests:
Update requests library to latest version (2.22.0) in requirements. (improvement) #4680
Additionally, I would actually document the other changes you made. For example, you also updated the GitPython version, removed --no-site-packages from the virtualenv calls, and tweaked the file and directory permissions for Travis. I would include bullets for all of those.
cognifloyd
force-pushed
the
changelog_for_master_build_fix
branch
from
2b4406d to
b2f4a51
Compare
cognifloyd
changed the title
cognifloyd
force-pushed
the
changelog_for_master_build_fix
branch
from
b2f4a51 to
21af554
Compare
Member
Author
|
Hey look here's another recent entry for requests. Lines 80 to 81 in 21af554 That's more what I'm doing so I followed that pattern. |
blag
suggested changes
Feb 21, 2020
cognifloyd
force-pushed
the
changelog_for_master_build_fix
branch
from
21af554 to
848fd76
Compare
blag
approved these changes
Feb 21, 2020
arm4b
previously requested changes
Feb 21, 2020
cognifloyd
force-pushed
the
changelog_for_master_build_fix
branch
from
848fd76 to
f2a41e0
Compare
Member
|
@cognifloyd @blag Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the changelog entries missing from #4869