Skip to content

Conversation

@cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Feb 22, 2020

This is a rebased version of #4862. It is here for future reference (to show how minimal the update is) when we want to consider moving to bionic. I will immediately close it.

Switches travis to use Bionic with Mongo 4.0

Mongo 3.4 is not available in Bionic, so 4.0 is required.
Also, the test thresholds were increased to account for increased test times due to the mongo update.

MongoDB 3.4 is not available on Bionic and 4.0 is already installed.
Mongo 4.0 significantly changes the test runtimes. 2x was too much of a
jump, so this is approximately 60s more than the last successful run
time. That comes out to (test time used to calculate in parentheses):

24% increase for "Unit Tests (Python 2.7 MongoDB 4.0)" (812s)
37% increase for "Integration Tests (Python 2.7)" (903s)
95% increase for "Lint Checks, Packs Tests (Python 2.7)" (490s)
71% increase for "Unit Tests, Pack Tests (Python 3.6)" (1101s)
252% increase for "Integration Tests (Python 3.6)" (1031s)

Note that this PR also fixes the Python 3.6 integration tests to
actually run in python 3.6 instead of 2.7, so that might account for
some of the significant test time increase.

When we move to python 3.7 that will probably decrease the py3 times.
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label Feb 22, 2020
@cognifloyd cognifloyd closed this Feb 22, 2020
@cognifloyd cognifloyd deleted the travis-bionic branch February 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S PR that changes 10-29 lines. Very easy to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant