Skip to content

#4828 - fix tag filter when querying actions #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arm4b merged 6 commits into from
Apr 10, 2020
Merged

#4828 - fix tag filter when querying actions #4874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ff872f
lookup tage values by tag.name instead of name
winem Feb 22, 2020
ad3b358
add changelog entry for the fixed tag filter - #4828
winem Feb 22, 2020
228cdff
update changelog entry
winem Feb 24, 2020
4664e52
Merge branch 'master' into fix/4828-filter-actions-by-tagname
blag Feb 25, 2020
deeec48
Merge branch 'master' into fix/4828-filter-actions-by-tagname
nmaludy Apr 8, 2020
4d1f9a1
Merge branch 'master' into fix/4828-filter-actions-by-tagname
armab Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ Changed

Fixed
~~~~~
* Fix the action query when filtering tags. The old implementation returned actions which have the
provided name as action name and not as tag name. (bug fix) #4828

Reported by @AngryDeveloper and contributed by Marcel Weinberg (@winem)
* Fix the passing of arrays to shell scripts where the arrays where not detected as such by the
st2 action_db utility. This caused arrays to be passed as Python lists serialized into a string.

Expand Down
2 changes: 1 addition & 1 deletion st2api/st2api/controllers/v1/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class ActionsController(resource.ContentPackResourceController):
supported_filters = {
'name': 'name',
'pack': 'pack',
'tags': 'name'
'tags': 'tag.name'
}

query_options = {
Expand Down