Pin build dependencies to single version and update instructions #4900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
nmaludy
approved these changes
Apr 3, 2020
…t still supports Python 2.7)
…k instructions for future developers
arm4b
reviewed
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #4895 to pin pip and setuptools dependencies to specific versions.
I picked the current latest versions because it's less work in the future.
I believe we will need to update these versions in many other repositories as well. This is simply the first one.
This PR fixes a bug in the
write-header.shscript so it now correctly copies the "magic comment" lines before injecting its comment header. Editors should now respect the encoding of the generateddist_utils.pyfiles. Additionally, I tweaked some of the behavior so it doesn't print lines that begin with# //(a C++-esque comment within a Python comment), and included instructions for re-generating all of the subpackagedist_utils.pyfiles, since I was not aware that this needed to be done when I changed the masterdist_utils.pyscript in #4895 and future developers may not know either. Ideally we would make this a CI lint check, but I don't think that's hugely necessary at this point.