Skip to content

Conversation

@punkrokk
Copy link
Member

@punkrokk punkrokk commented Apr 3, 2020

Fixes: #4890 to support new Paramiko keys.

Notes:
Paramiko Issue: paramiko/paramiko#1565 (released in v2.7.1)
Changelog in v2.7.1: http://www.paramiko.org/changelog.html

@punkrokk punkrokk added this to the 3.2.0 milestone Apr 3, 2020
@punkrokk punkrokk requested review from arm4b, blag and nmaludy April 3, 2020 17:27
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Apr 3, 2020
Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ Ed25519 keys.

Fixed typo in referenced issue.
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmaludy
Copy link
Member

nmaludy commented Apr 8, 2020

@armab FYI i created a suggestion and added it to this PR that fixes the referenced version in the CHANGELOG. Should be good to go now.

@punkrokk
Copy link
Member Author

punkrokk commented Apr 8, 2020 via email

@punkrokk
Copy link
Member Author

punkrokk commented Apr 8, 2020

@armab before we merge, I don't understand how the .travis file ended up here

@punkrokk
Copy link
Member Author

punkrokk commented Apr 8, 2020

@blag I think you accidentally commit the travis file here.

@arm4b
Copy link
Member

arm4b commented Apr 8, 2020

That's fine. I'm just happy @blag didn't accidentally commit more unpinning pip version changes to this PR 😄

@punkrokk punkrokk merged commit 71a40d2 into master Apr 8, 2020
@punkrokk punkrokk deleted the update_parakmiko branch April 8, 2020 16:32
@blag
Copy link
Contributor

blag commented Apr 16, 2020

@armab I had to resist the urge! 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external dependency size/XS PR that changes 0-9 lines. Quick fix/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

newer sshkeys are not working in paramiko

5 participants