Skip to content

Conversation

@winem
Copy link
Contributor

@winem winem commented Apr 24, 2020

This PR fixes the issue I found tonight when testing the tag filter as reported in #4918 and adds unit tests to test the API with actions filtered by the name or tag.

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Apr 24, 2020
@winem winem changed the title Fix issue in the Fix typo in the supported API filters when filtering packs Apr 24, 2020
Copy link
Member

@Kami Kami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks 👍

@winem
Copy link
Contributor Author

winem commented Apr 24, 2020

Please don't merge it yet, I'm currently fixing the new unit tests to avoid that this feature breaks unnoticed again. Will drop another comment and remove the WIP: once the unit tests were successful.

@winem winem changed the title Fix typo in the supported API filters when filtering packs WIP: Fix typo in the supported API filters when filtering packs Apr 24, 2020
@arm4b arm4b added this to the 3.2.0 milestone Apr 24, 2020
@arm4b arm4b marked this pull request as draft April 24, 2020 15:04
@arm4b
Copy link
Member

arm4b commented Apr 24, 2020

👍 We definitely want to include this fix for v3.2.
@winem Just converted this PR to draft to make sure we don't merge it before you're ready.

See https://github.blog/2019-02-14-introducing-draft-pull-requests/

@winem
Copy link
Contributor Author

winem commented Apr 24, 2020

@armab thanks for the support. I think and hope that especially the unit tests will be useful in the future.

The tests run fine when I run them locally with nosetests and I can not really see the root cause for the failing travis tests in the code itself. It looks more like a infrastructure issue or an issue with external dependencies (services, dbs, ...).

I'll remove the WIP flag now and would like to ask for a 2nd opinion regarding the failing tests.

@winem winem changed the title WIP: Fix typo in the supported API filters when filtering packs Fix typo in the supported API filters when filtering packs Apr 24, 2020
@arm4b
Copy link
Member

arm4b commented Apr 24, 2020

@winem I just re-started CI jobs and they're green now.
Probably was a temporary failure from TravisCI.

@arm4b arm4b marked this pull request as ready for review April 24, 2020 21:30
@arm4b arm4b merged commit 137020a into StackStorm:master Apr 24, 2020
@winem winem marked this pull request as ready for review April 24, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API bug service: api size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants