-
-
Notifications
You must be signed in to change notification settings - Fork 782
Fix typo in the supported API filters when filtering packs #4919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in the supported API filters when filtering packs #4919
Conversation
…nem/st2 into issue-4918-pack-api-tag-filter-typo
Kami
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks 👍
|
Please don't merge it yet, I'm currently fixing the new unit tests to avoid that this feature breaks unnoticed again. Will drop another comment and remove the |
… format string on __do_get_actions_by_url_parameter
…ribute which accepts the attribute as parameter * add unit test to filter actions by the pack name via url parameters
|
👍 We definitely want to include this fix for See https://github.blog/2019-02-14-introducing-draft-pull-requests/ |
|
@armab thanks for the support. I think and hope that especially the unit tests will be useful in the future. The tests run fine when I run them locally with nosetests and I can not really see the root cause for the failing travis tests in the code itself. It looks more like a infrastructure issue or an issue with external dependencies (services, dbs, ...). I'll remove the WIP flag now and would like to ask for a 2nd opinion regarding the failing tests. |
|
@winem I just re-started CI jobs and they're green now. |
This PR fixes the issue I found tonight when testing the tag filter as reported in #4918 and adds unit tests to test the API with actions filtered by the name or tag.