fix netstat action in linux pack #4947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
nmaludy
suggested changes
May 13, 2020
Member
nmaludy
left a comment
nmaludy
left a comment
There was a problem hiding this comment.
Good find!
Could you please add a CHANGELOG entry for this.
Contributor
Author
done 👍 |
Member
|
@Sheshagiri Can you also try to fix the lint failures in https://travis-ci.org/github/StackStorm/st2/jobs/686593938#L2218-L2219. Looks like a small change, but if it's not, - you can start a new PR. It's something new as master is green and I don't think failures are related to your change. Probably just a recent upstream update that broke it. |
pull-request-size
bot
added
size/S
arm4b
approved these changes
May 13, 2020
nmaludy
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like the
typeattribute is missing fornetstataction in Linux pack because of which the action in not usable.closes: #4946