Pin pip consistently in one place across the targets, fix st2docs build #4957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
pull-request-size
bot
added
size/M
arm4b
commented
May 23, 2020
| # If you update these versions, make sure you update the versions in the .st2client-install-check | ||
| # and the requirements targets in the Makefile to match | ||
| - pip install --upgrade "pip==20.0.2" | ||
| - sudo pip install --upgrade "virtualenv==16.6.0" |
Member
Author
There was a problem hiding this comment.
FYI pinning virtualenv here never really worked.
In Travis environment:
virtualenv --version
16.1.0
for py2 env
and
virtualenv --version
16.0.0
for py3 env
Member
Author
There was a problem hiding this comment.
It turns out that's because different virtualenv binaries were created when we installed/upgraded it with sudo and used one without 🤦
pull-request-size
bot
added
size/S
arm4b
changed the title
Member
Author
|
There are a bunch of st2docs PRs which merging is blocked by this CI failure and I'd like us to fix this ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
st2docsbuild which is based onst2makefile started to fail (https://circleci.com/gh/StackStorm/st2docs/2529) due to upstream pip updated to latest20.1.1, while we failed to pin it to20.0.2. Thanks to @winem for the find.We should not pin
pipin files like.travis.yml, but instead use single consistent way and not hack across the many places as other systems rely on st2 makefiles for the builds.Related: StackStorm/community#2
This change sets pip version in one Makefile place and fixes st2docs builds.