Skip to content

Conversation

@nmaludy
Copy link
Member

@nmaludy nmaludy commented Dec 1, 2020

TODO List

  • TASK=ci-checks
  • TASK=compilepy3
  • TASK=ci-packs-tests
  • TASK=ci-unit
  • TASK=ci-integration
  • caching
  • apt sources
  • install script
  • before script
  • script
  • notifications

Status

Everything has been converted over except for Integration test and Slack notifications.

Integration Tests

  • The RabbitMQ "service" container that we use currently can not start up with our custom config and SSL certificates required in integration tests: st2common/tests/integration/test_rabbitmq_ssl_listener.py
    • To "fix" this we need to install/config/run RabbitMQ ourselves, but getting this working in GHA has proven to be difficult (unable to install rabbitqmq-server apt package successfully)
  • Ran into issues with the python_action_process_wrapper tests (contrib/runners/python_runner/tests/integration/test_python_action_process_wrapper.py).

@nmaludy nmaludy self-assigned this Dec 1, 2020
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Dec 1, 2020
@nmaludy nmaludy force-pushed the feature/github-actions branch 11 times, most recently from ae382fd to 4f9e37c Compare December 2, 2020 02:38
@nmaludy nmaludy force-pushed the feature/github-actions branch from 4f9e37c to 0545040 Compare December 2, 2020 02:40
@nmaludy nmaludy force-pushed the feature/github-actions branch from 6face28 to 62439c6 Compare December 2, 2020 03:13
@nmaludy nmaludy force-pushed the feature/github-actions branch 11 times, most recently from d5daaa9 to 7441ea5 Compare December 2, 2020 05:04
…fication

Slack notification on failed Github Action executions on the master branch
@blag
Copy link
Contributor

blag commented Jan 21, 2021

@winem Can you push this PR to completion, or at least partial completion? If we only offload four of the five TASKs to GitHub Actions, that's will still be very useful for us. Travis CI latencies are terrible, so we still gain something even if we don't completely move off of their platform entirely.

@winem
Copy link
Contributor

winem commented Jan 21, 2021

@blag yes, I'll tackle the rabbitmq issue.

@arm4b
Copy link
Member

arm4b commented Jan 21, 2021

Thanks @winem.

Quick context:

Per discussion, the transient agreement was to move the Unit tests to Github Actions,
while keeping the Integration Tests in TravisCI. The RabbitMQ (Integration Tests) issue could be postponed that way.

That would already help a lot.

@arm4b
Copy link
Member

arm4b commented Jan 21, 2021

To merge this PR we need to make sure:

  • Unit Tests + Checks are running in GH Actions (done)
  • Unit Tests in GH Actions are green: 90% done
  • Only Integration Tests are running in TravisCI (done)
  • Integration Tests in TravisCI are green (as before)

@winem
Copy link
Contributor

winem commented Jan 22, 2021

@armab I don't see any failing unit tests when I take a look at https://github.com/StackStorm/st2/runs/1704636828?check_suite_focus=true for example. All the exceptions that are shown are expected and the tests as such pass.

Please enlighten me. Looks like I miss something here. I'm happy to tackle remaining tests over the weekend.

@blag blag merged commit d9f0f19 into master Jan 22, 2021
@blag blag deleted the feature/github-actions branch January 22, 2021 09:39
@blag
Copy link
Contributor

blag commented Jan 22, 2021

🎉

@arm4b
Copy link
Member

arm4b commented Jan 22, 2021

That was a great team effort @nmaludy @blag @winem! 👍
Really happy to see this merged and part of our tests running in GH Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature infrastructure: ci/cd size/L PR that changes 100-499 lines. Requires some effort to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants