Fix implicit relative imports in pack actions #5127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Contributor
Author
|
Now that I have a bit more time before the v3.4 release, I'd like to add some additional tests for this before it's merged. |
Contributor
Author
|
Closed by #5142. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were a little overzealous when ripping out Python 2 support code, and removed some Python 3 support as well. This PR adds that feature back in.
This PR re-enables pack authors to use implicit relative import paths when importing from
actions/lib(eg: from lib.mymodule import myfunction`).Python 3 has removed support for implicit relative imports for legitimate reasons, so we should try to push pack authors to use explicit relative imports (eg:
from .lib.mymodule import myfunction- note the preceding.beforelib.mymodule). But we should both document this quirk and take steps to remove it in a future ST2 release (tracking issue incoming).Closes #5126.