-
-
Notifications
You must be signed in to change notification settings - Fork 782
Update more dependencies to various stable versions #5237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
so we need to pass valid cert (or disable cert validation) for that test to pass.
|
OK, tests exposed an issue with kombu / pyaqmp upgrade.
Problem also is that one of the tests is mixing connection parameters in URL + connection parameters via config option - and that doesn't work well / correctly when trying to use custom ca cert for ssl validation. If user wants to use custom ssl options, they need to do that via config option and not via url. I think I can fix / change that test and document that behavior in docs and upgrade notes and we should be fine. |
due to the ssl.cert_reqs default value changing from ssl.NONE to ssl.CERT_REQUIRED.
|
Thanks for getting this done. |
This PR updates more dependencies to latest stable versions.
Only potentially more risky ones could be kombu / amqp, but I went over the changelog and integration + end to end tests should catch if there are any issues.