Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Apr 15, 2021

This PR updates more dependencies to latest stable versions.

Only potentially more risky ones could be kombu / amqp, but I went over the changelog and integration + end to end tests should catch if there are any issues.

@Kami Kami added this to the 3.5.0 milestone Apr 15, 2021
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Apr 15, 2021
Kami added 2 commits April 16, 2021 22:47
so we need to pass valid cert (or disable cert validation) for that test
to pass.
@Kami
Copy link
Member Author

Kami commented Apr 16, 2021

OK, tests exposed an issue with kombu / pyaqmp upgrade.

ssl.cert_reqs now defaults to ssl.CERT_REQUIRED is ?ssl=true is passed via URL which is a good and right thing, but our existing tests rely on that value defaulting to cert.none (which used to be true in older versions. Because od that, integration tests will fail since we use a custom cert for the server which is not part of the system ca bundle.

Problem also is that one of the tests is mixing connection parameters in URL + connection parameters via config option - and that doesn't work well / correctly when trying to use custom ca cert for ssl validation. If user wants to use custom ssl options, they need to do that via config option and not via url.

I think I can fix / change that test and document that behavior in docs and upgrade notes and we should be fine.

due to the ssl.cert_reqs default value changing from ssl.NONE to
ssl.CERT_REQUIRED.
@Kami Kami merged commit 3734d75 into master Apr 21, 2021
@Kami Kami deleted the deps_update_2 branch April 21, 2021 21:40
@blag
Copy link
Contributor

blag commented Apr 21, 2021

Thanks for getting this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external dependency size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants