Add focal and remove xenial #5283
Conversation
pull-request-size
bot
added
the
size/XS
blag
left a comment
blag
left a comment
There was a problem hiding this comment.
Aside from one small, possibly necessary fix, this looks good. Thanks!
I'm assuming that it doesn't matter what version of Python our CircleCI jobs run in (currently using: circleci/python:3.6 image), since they are packaged within Docker containers, and the Ubuntu Focal packaging container/s will be running Python 3.8.
.circleci/config.yml
Outdated
| # but the fastest is still ~x1.5-2 slower, comparing to Travis | ||
| machine: true | ||
| parallelism: 4 | ||
| parallelism: 3 |
There was a problem hiding this comment.
| parallelism: 3 | |
| parallelism: 4 |
If we're adding focal at the same time that we're removing xenial, then let's leave this alone.
There was a problem hiding this comment.
@blag Fixed...
Also yes my understanding is the same. It does the building and testing in the docker containers, and so the focal containers have python 3.8 so I believe this is all good. As the image is just what you run the essentially commands to pull up docker run in.
Update circleci to run packages for focal and remove xenial