Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Jun 17, 2021

This PR adds missing setup.py scripts entry so the new migration script gets installed into virtualenv bin/ directory.

StackStorm/community#81 (comment)

@Kami Kami added this to the 3.5.0 milestone Jun 17, 2021
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Jun 17, 2021
@amanda11
Copy link
Contributor

amanda11 commented Jun 17, 2021

@Kami Note, the python module also isn't present in the package at the moment.

$ cd /opt/stackstorm
[centos@el8-man-install stackstorm]$ find . -name st2_migrate_db_dict_field_values.py
[centos@el8-man-install stackstorm]$ 

@Kami
Copy link
Member Author

Kami commented Jun 17, 2021

@amanda11 Python module is just a symlink to st2-migrate-db-dict-field-values and it's just needed for testing purposes (unit tests) and nothing else.

Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the migration script is now present in the RPM built from this PR.

@amanda11 amanda11 merged commit 2f918cd into master Jun 17, 2021
@amanda11 amanda11 deleted the add_missing_setup_py_entry branch June 17, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS PR that changes 0-9 lines. Quick fix/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants