Skip to content

Conversation

@blag
Copy link
Contributor

@blag blag commented Jul 5, 2021

GHA CI is failing because our release scripts insert single quotes instead of double quotes:

sed -i -e "s/\(__version__ = \).*/\1'${VERSION}'/" ${INIT_FILE}
#                                   ^          ^

But black forces us to use double quotes:

================== black-check ====================

# st2 components
===========================================================
Running black on st2actions
===========================================================
would reformat /home/runner/work/st2/st2/st2actions/st2actions/__init__.py
Oh no! 💥 💔 💥
1 file would be reformatted, 59 files would be left unchanged.
make: *** [Makefile:372: .black-check] Error 1
Script done, file is typescript
Error: Process completed with exit code 2.

Running black manually:

diff --git a/st2actions/st2actions/__init__.py b/st2actions/st2actions/__init__.py
index 2e5ec8277..18f4135fa 100644
--- a/st2actions/st2actions/__init__.py
+++ b/st2actions/st2actions/__init__.py
@@ -13,4 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.

-__version__ = '3.6dev'
+__version__ = "3.6dev"

This PR switches to using double quotes in all of the __init__.py files for the various packages in the codebase.

The corresponding PR to fix our release scripts is StackStorm/st2cd#464.

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Jul 5, 2021
@blag blag added this to the 3.5.0 milestone Jul 5, 2021
Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amanda11 amanda11 modified the milestones: 3.5.0, 3.6.0 Jul 5, 2021
@arm4b arm4b merged commit f1e895f into master Jul 5, 2021
@arm4b arm4b deleted the fix-init-version-quotes branch July 5, 2021 13:40
@arm4b
Copy link
Member

arm4b commented Jul 5, 2021

Thanks! Back to green builds ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix complexity:easy size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants