Skip to content

Remove deprecated python3 flag #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanda11 merged 4 commits into from
Jul 18, 2021
Merged

Remove deprecated python3 flag #5305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e52657
Remove deprecated python3 flag
amanda11 Jul 15, 2021
8513f11
Add PR number to changelog
amanda11 Jul 15, 2021
d1040b8
Remove unused import
amanda11 Jul 15, 2021
245e93b
Merge branch 'master' into remove_python3
blag Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ in development
Changed
~~~~~~~

* Removed --python3 deprecated flag from st2client. #5305

Contributed by Amanda McGuinness (@amanda11 Ammeon Solutions)

Contributed by @blag.
* Fixed ``__init__.py`` files to use double quotes to better align with black linting #5299

Contributed by @blag.
Expand Down
13 changes: 0 additions & 13 deletions st2client/st2client/commands/pack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

import six
import editor
import warnings
import yaml

from st2client.models import Config
Expand Down Expand Up @@ -255,12 +254,6 @@ def __init__(self, resource, *args, **kwargs):
help="Name of the %s in Exchange, or a git repo URL."
% resource.get_plural_display_name().lower(),
)
self.parser.add_argument(
"--python3",
action="store_true",
default=False,
help="Use Python 3 binary for pack virtual environment.",
)
self.parser.add_argument(
"--force",
action="store_true",
Expand All @@ -282,12 +275,6 @@ def run(self, args, **kwargs):
if not is_structured_output:
self._get_content_counts_for_pack(args, **kwargs)

if args.python3:
warnings.warn(
"DEPRECATION WARNING: --python3 flag is ignored and will be removed "
"in v3.5.0 as StackStorm now runs with python3 only"
)

return self.manager.install(
args.packs,
force=args.force,
Expand Down