Skip to content

Fix st2-self-check script reporting success on failed runs #5487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arm4b merged 3 commits into from
Dec 9, 2021
Merged

Fix st2-self-check script reporting success on failed runs #5487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3c4491
Fix st2-self-check script reporting success on failed runs
arm4b Dec 8, 2021
8e09d0e
Add the changelog for #5487
arm4b Dec 8, 2021
69ba1d4
Make sure the newlines are preserved in the output from the command s…
arm4b Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ Fixed

Contributed by @khushboobhatia01

* Fix ``st2-self-check`` script reporting falsey success when the nested workflows runs failed. #5487

3.6.0 - October 29, 2021
------------------------

Expand Down
4 changes: 2 additions & 2 deletions st2common/bin/st2-self-check
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ do

START_TS=$(date +%s)
OUTPUT=$(st2 run ${TEST} protocol=${PROTOCOL} token=${ST2_AUTH_TOKEN})
echo ${OUTPUT} | grep "status" | grep -q "succeeded"
echo "${OUTPUT}" | grep "status" | grep -q "succeeded"
EXIT_CODE=$?
END_TS=$(date +%s)
DURATION=$(expr ${END_TS} - ${START_TS})
Expand All @@ -159,7 +159,7 @@ if [ ${RUN_ORQUESTA_TESTS} = "true" ]; then

START_TS=$(date +%s)
OUTPUT=$(st2 run examples.orquesta-examples)
echo ${OUTPUT} | grep "status" | grep -q "succeeded"
echo "${OUTPUT}" | grep "status" | grep -q "succeeded"
EXIT_CODE=$?
END_TS=$(date +%s)
DURATION=$(expr ${END_TS} - ${START_TS})
Expand Down