-
-
Notifications
You must be signed in to change notification settings - Fork 782
Router fix to handle url encoded form payload #5513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sravanthi Konduru seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
9ab7c2c to
e769c50
Compare
m4dcoder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sravs-dev Thanks for the contrib! Can you add a unit test at https://github.com/StackStorm/st2/blob/master/st2api/tests/unit/controllers/v1/test_base.py?
Sure, will add |
@m4dcoder Is there a setup guide that I can follow for running tests? I guess the tests expect mongo DB to be running in the localhost? |
|
@sravs-dev Thanks for the fix! From the CI issues (https://github.com/StackStorm/st2/runs/4706277178), only the lining is failing for Could you please also update the |
@armab Thanks for checking, I fixed the format issue and updated changelog. Need approval to run CI checks. |
|
@sravs-dev Thanks! All good, the only missing is the CLA check. Looks like your github account wasn't associated with the commits.
Could you try that by adding the email associated with those commits to your github account? See more details in the: #5513 (comment) |
Fix for the issue #5512
When there is a POST request with payload type "application/x-www-form-urlencoded" , Input body is of type bytes. We need to convert it to string before processing