check if value is actually jinja before adding as template #5556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
cognifloyd
approved these changes
Jan 26, 2022
arm4b
suggested changes
Jan 26, 2022
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Please include a Changelog for this fix.
Did you get an exception somewhere, how the error looked like?
A more specific example with steps to reproduce and log in the first message would help for the future history and others hitting the same issue.
Contributor
Author
|
If your parameter value has a |
arm4b
approved these changes
Jan 26, 2022
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Thanks for Changelog and additional context! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check if the value is actually jinja and not a string like
{"someurl": "http://test?value={{test"}