-
-
Notifications
You must be signed in to change notification settings - Fork 782
Add garbage collection for trace and rule_enforcement models #5596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #!/usr/bin/env python | ||
| # Licensed to the StackStorm, Inc ('StackStorm') under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import sys | ||
|
|
||
| from st2common.cmd.purge_rule_enforcement import main | ||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #!/usr/bin/env python | ||
| # Licensed to the StackStorm, Inc ('StackStorm') under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import sys | ||
|
|
||
| from st2common.cmd.purge_trace import main | ||
|
|
||
| if __name__ == "__main__": | ||
| sys.exit(main()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| # Copyright 2022 The StackStorm Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
|
|
||
| """ | ||
| A utility script that purges trigger instances older than certain | ||
| timestamp. | ||
|
|
||
| *** RISK RISK RISK. You will lose data. Run at your own risk. *** | ||
| """ | ||
|
|
||
| from __future__ import absolute_import | ||
|
|
||
| from datetime import datetime | ||
|
|
||
| import six | ||
| import pytz | ||
| from oslo_config import cfg | ||
|
|
||
| from st2common import config | ||
| from st2common import log as logging | ||
| from st2common.config import do_register_cli_opts | ||
| from st2common.script_setup import setup as common_setup | ||
| from st2common.script_setup import teardown as common_teardown | ||
| from st2common.constants.exit_codes import SUCCESS_EXIT_CODE | ||
| from st2common.constants.exit_codes import FAILURE_EXIT_CODE | ||
| from st2common.garbage_collection.rule_enforcement import purge_rule_enforcement | ||
|
|
||
| __all__ = ["main"] | ||
|
|
||
| LOG = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def _register_cli_opts(): | ||
| cli_opts = [ | ||
| cfg.StrOpt( | ||
| "timestamp", | ||
| default=None, | ||
| help="Will delete rule_enforcement instances older than " | ||
| + "this UTC timestamp. " | ||
| + "Example value: 2015-03-13T19:01:27.255542Z", | ||
| ) | ||
| ] | ||
| do_register_cli_opts(cli_opts) | ||
|
|
||
|
|
||
| def main(): | ||
| _register_cli_opts() | ||
| common_setup(config=config, setup_db=True, register_mq_exchanges=False) | ||
|
|
||
| # Get config values | ||
| timestamp = cfg.CONF.timestamp | ||
|
|
||
| if not timestamp: | ||
| LOG.error("Please supply a timestamp for purging models. Aborting.") | ||
| return 1 | ||
| else: | ||
| timestamp = datetime.strptime(timestamp, "%Y-%m-%dT%H:%M:%S.%fZ") | ||
| timestamp = timestamp.replace(tzinfo=pytz.UTC) | ||
|
|
||
| # Purge models. | ||
| try: | ||
| purge_rule_enforcement(logger=LOG, timestamp=timestamp) | ||
| except Exception as e: | ||
| LOG.exception(six.text_type(e)) | ||
| return FAILURE_EXIT_CODE | ||
| finally: | ||
| common_teardown() | ||
|
|
||
| return SUCCESS_EXIT_CODE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| # Copyright 2022 The StackStorm Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
|
|
||
| """ | ||
| A utility script that purges trigger instances older than certain | ||
| timestamp. | ||
|
|
||
| *** RISK RISK RISK. You will lose data. Run at your own risk. *** | ||
| """ | ||
|
|
||
| from __future__ import absolute_import | ||
|
|
||
| from datetime import datetime | ||
|
|
||
| import six | ||
| import pytz | ||
| from oslo_config import cfg | ||
|
|
||
| from st2common import config | ||
| from st2common import log as logging | ||
| from st2common.config import do_register_cli_opts | ||
| from st2common.script_setup import setup as common_setup | ||
| from st2common.script_setup import teardown as common_teardown | ||
| from st2common.constants.exit_codes import SUCCESS_EXIT_CODE | ||
| from st2common.constants.exit_codes import FAILURE_EXIT_CODE | ||
| from st2common.garbage_collection.trace import purge_trace | ||
|
|
||
| __all__ = ["main"] | ||
|
|
||
| LOG = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def _register_cli_opts(): | ||
| cli_opts = [ | ||
| cfg.StrOpt( | ||
| "timestamp", | ||
| default=None, | ||
| help="Will delete trace instances older than " | ||
| + "this UTC timestamp. " | ||
| + "Example value: 2015-03-13T19:01:27.255542Z", | ||
| ) | ||
| ] | ||
| do_register_cli_opts(cli_opts) | ||
|
|
||
|
|
||
| def main(): | ||
| _register_cli_opts() | ||
| common_setup(config=config, setup_db=True, register_mq_exchanges=False) | ||
|
|
||
| # Get config values | ||
| timestamp = cfg.CONF.timestamp | ||
|
|
||
| if not timestamp: | ||
| LOG.error("Please supply a timestamp for purging models. Aborting.") | ||
| return 1 | ||
| else: | ||
| timestamp = datetime.strptime(timestamp, "%Y-%m-%dT%H:%M:%S.%fZ") | ||
| timestamp = timestamp.replace(tzinfo=pytz.UTC) | ||
|
|
||
| # Purge models. | ||
| try: | ||
| purge_trace(logger=LOG, timestamp=timestamp) | ||
| except Exception as e: | ||
| LOG.exception(six.text_type(e)) | ||
| return FAILURE_EXIT_CODE | ||
| finally: | ||
| common_teardown() | ||
|
|
||
| return SUCCESS_EXIT_CODE |
67 changes: 67 additions & 0 deletions
67
st2common/st2common/garbage_collection/rule_enforcement.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| # Copyright 2022 The StackStorm Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """ | ||
| Module with utility functions for purging old trigger instance objects. | ||
| """ | ||
|
|
||
| from __future__ import absolute_import | ||
|
|
||
| import six | ||
| from mongoengine.errors import InvalidQueryError | ||
|
|
||
| from st2common.persistence.rule_enforcement import RuleEnforcement | ||
| from st2common.util import isotime | ||
|
|
||
| __all__ = ["purge_rule_enforcement"] | ||
|
|
||
|
|
||
| def purge_rule_enforcement(logger, timestamp): | ||
| """ | ||
| :param timestamp: Rule enforcement instances older than this timestamp will be deleted. | ||
| :type timestamp: ``datetime.datetime | ||
| """ | ||
| if not timestamp: | ||
| raise ValueError("Specify a valid timestamp to purge.") | ||
|
|
||
| logger.info( | ||
| "Purging rule enforcements older than timestamp: %s" | ||
| % timestamp.strftime("%Y-%m-%dT%H:%M:%S.%fZ") | ||
| ) | ||
|
|
||
| query_filters = {"enforced_at__lt": isotime.parse(timestamp)} | ||
|
|
||
| try: | ||
| deleted_count = RuleEnforcement.delete_by_query(**query_filters) | ||
| except InvalidQueryError as e: | ||
| msg = ( | ||
| "Bad query (%s) used to delete rule enforcements: %s" | ||
| "Please contact support." | ||
| % ( | ||
| query_filters, | ||
| six.text_type(e), | ||
| ) | ||
| ) | ||
| raise InvalidQueryError(msg) | ||
| except: | ||
| logger.exception( | ||
| "Deleting rule enforcements using query_filters %s failed.", query_filters | ||
| ) | ||
| else: | ||
| logger.info("Deleted %s rule enforcement objects" % (deleted_count)) | ||
|
|
||
| # Print stats | ||
| logger.info( | ||
| "All rule enforcement models older than timestamp %s were deleted.", timestamp | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| # Copyright 2022 The StackStorm Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """ | ||
| Module with utility functions for purging old trigger instance objects. | ||
| """ | ||
|
|
||
| from __future__ import absolute_import | ||
|
|
||
| import six | ||
| from mongoengine.errors import InvalidQueryError | ||
|
|
||
| from st2common.persistence.trace import Trace | ||
| from st2common.util import isotime | ||
|
|
||
| __all__ = ["purge_trace"] | ||
|
|
||
|
|
||
| def purge_trace(logger, timestamp): | ||
| """ | ||
| :param timestamp: Trace instances older than this timestamp will be deleted. | ||
| :type timestamp: ``datetime.datetime | ||
| """ | ||
| if not timestamp: | ||
| raise ValueError("Specify a valid timestamp to purge.") | ||
|
|
||
| logger.info( | ||
| "Purging trace instances older than timestamp: %s" | ||
| % timestamp.strftime("%Y-%m-%dT%H:%M:%S.%fZ") | ||
| ) | ||
|
|
||
| query_filters = {"start_timestamp__lt": isotime.parse(timestamp)} | ||
|
|
||
| try: | ||
| deleted_count = Trace.delete_by_query(**query_filters) | ||
| except InvalidQueryError as e: | ||
| msg = ( | ||
| "Bad query (%s) used to delete trace instances: %s" | ||
| "Please contact support." | ||
| % ( | ||
| query_filters, | ||
| six.text_type(e), | ||
| ) | ||
| ) | ||
| raise InvalidQueryError(msg) | ||
| except: | ||
| logger.exception( | ||
| "Deleting trace instances using query_filters %s failed.", query_filters | ||
| ) | ||
| else: | ||
| logger.info("Deleted %s trace objects" % (deleted_count)) | ||
|
|
||
| # Print stats | ||
| logger.info("All trace models older than timestamp %s were deleted.", timestamp) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency it would be good to use plural form of the name here as well - e.g. purge-traces and purge-rule-enforcements.