Changes to support new purge task executions and purge workflows #5605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
======================================================================
1) ERROR: test_run (test_action_unload.UnloadActionTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
tests/test_action_unload.py line 100 in test_run
action.run(packs=[pack])
actions/pack_mgmt/unload.py line 68 in run
self._unregister_rules(pack=pack)
actions/pack_mgmt/unload.py line 99 in _unregister_rules
cleanup_trigger_db_for_rule(rule_db=rule_db)
/home/runner/work/st2/st2/st2common/st2common/services/triggers.py line 332 in cleanup_trigger_db_for_rule
Trigger.delete_if_unreferenced(existing_trigger_db)
/home/runner/work/st2/st2/st2common/st2common/persistence/trigger.py line 61 in delete_if_unreferenced
cls._get_impl().delete_by_query(**delete_query)
/home/runner/work/st2/st2/st2common/st2common/models/db/__init__.py line 479 in delete_by_query
super(self)
TypeError: super() argument 1 must be type, not MongoDBAccess
pull-request-size
bot
added
the
size/XL
amanda11
changed the title
amanda11
changed the title
arm4b
approved these changes
Apr 1, 2022
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Awesome work @amanda11 and @cognifloyd bringing the stale #4924 into life 👍
+ a few misc spacing cleanups
cognifloyd
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of PR #4924
Closes #4939
Closes #4924