Add backward compatibility to secret masking for output schema #5783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new output schema using full JSON schema was introduced and secrets previously masked using the legacy output schema now being displayed as plain text. To prevent security relative issues, add backward compatibility to secret masking. Full output schema validattion will need to be migrated to the new schema.
pull-request-size
bot
added
the
size/M
cognifloyd
reviewed
Oct 23, 2022
arm4b
reviewed
Oct 24, 2022
Contributor
Author
|
ok. I'll update the changelog and description here. |
m4dcoder
changed the title
m4dcoder
changed the title
m4dcoder
changed the title
cognifloyd
approved these changes
Oct 26, 2022
Member
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
I cleaned up the test name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add backward compatibility to secret masking introduced in #5319 to prevent security-relative issues. Migration to the new schema is required to take advantage of the full output schema validation.