Skip to content

For "local-shell-script" runner, on readonly filesystems, don't attempt to run chmod +x on script_action. #6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arm4b merged 2 commits into from
Nov 28, 2023
Merged

For "local-shell-script" runner, on readonly filesystems, don't attempt to run chmod +x on script_action. #6073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e05858d
Only run chmod +x on writable file systems - fixes #5591
jk464 Nov 24, 2023
8b794cc
Merge branch 'master' into bugfix/5591
arm4b Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ Fixed
* Update importlib-metadata from 3.10.1 to 4.8.3 for py3.6 and to 4.10.1 for py3.8 (security). #6072
Contributed by @jk464

* For "local-shell-script" runner, on readonly filesystems, don't attempt to run chmod +x on script_action. Fixes #5591
Contributed by @jk464

Added
~~~~~
* Move `git clone` to `user_home/.st2packs` #5845
Expand Down
5 changes: 4 additions & 1 deletion contrib/runners/local_runner/local_runner/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,10 @@ def _run(self, action):
sanitized_args = action.get_sanitized_full_command_string()

# For consistency with the old Fabric based runner, make sure the file is executable
if script_action:
# Also check to ensure not Read-only file system
if script_action and not bool(
os.statvfs(self.entry_point).f_flag & os.ST_RDONLY
):
script_local_path_abs = self.entry_point
args = "chmod +x %s ; %s" % (script_local_path_abs, args)
sanitized_args = "chmod +x %s ; %s" % (
Expand Down