Upgrade Pantsbuild to 2.18 #6120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Lockfile diff: lockfiles/st2.lock [st2] == Upgraded dependencies == argcomplete 3.2.2 --> 3.2.3 cachetools 5.3.2 --> 5.3.3 cryptography 42.0.3 --> 42.0.5 debtcollector 2.5.0 --> 3.0.0 filelock 3.13.1 --> 3.13.3 futurist 2.4.1 --> 3.0.0 gitpython 3.1.42 --> 3.1.43 graphviz 0.20.1 --> 0.20.3 importlib-metadata 7.0.1 --> 7.1.0 msgpack 1.0.7 --> 1.0.8 netaddr 1.1.0 --> 1.2.1 orjson 3.9.14 --> 3.10.0 oslo-i18n 6.2.0 --> 6.3.0 oslo-serialization 5.3.0 --> 5.4.0 packaging 23.2 --> 24.0 prettytable 3.9.0 --> 3.10.0 pyasn1 0.5.1 --> 0.6.0 pyasn1-modules 0.3.0 --> 0.4.0 pycparser 2.21 --> 2.22 pyparsing 3.1.1 --> 3.1.2 pytest 8.0.0 --> 8.1.1 python-dateutil 2.8.2 --> 2.9.0.post0 redis 5.0.1 --> 5.0.3 setuptools 69.1.0 --> 69.2.0 tooz 5.0.0 --> 6.1.0 urllib3 2.2.0 --> 2.2.1 virtualenv 20.25.0 --> 20.25.1 wheel 0.42.0 --> 0.43.0 yaql 2.0.1 --> 3.0.0 zipp 3.17.0 --> 3.18.1 Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == pantsbuild-pants 2.17.1 --> 2.18.3 pantsbuild-pants-testutil 2.17.1 --> 2.18.3 pyparsing 3.1.1 --> 3.1.2 == Removed dependencies == importlib-resources 5.0.7 Lockfile diff: lockfiles/twine.lock [twine] == Upgraded dependencies == certifi 2023.11.17 --> 2024.2.2 cryptography 42.0.1 --> 42.0.5 importlib-metadata 7.0.1 --> 7.1.0 importlib-resources 6.1.1 --> 6.4.0 jaraco-classes 3.3.0 --> 3.4.0 keyring 24.3.0 --> 25.1.0 nh3 0.2.15 --> 0.2.17 pkginfo 1.9.6 --> 1.10.0 pycparser 2.21 --> 2.22 readme-renderer 42.0 --> 43.0 tqdm 4.66.1 --> 4.66.2 urllib3 2.1.0 --> 2.2.1 zipp 3.17.0 --> 3.18.1 == Added dependencies == jaraco-context 4.3.0 jaraco-functools 4.0.0 Lockfile diff: lockfiles/flake8.lock [flake8] == Upgraded dependencies == setuptools 69.0.3 --> 69.2.0 Lockfile diff: lockfiles/pytest.lock [pytest] == Upgraded dependencies == coverage 7.4.1 --> 7.4.4 importlib-metadata 7.0.1 --> 7.1.0 packaging 23.2 --> 24.0 zipp 3.17.0 --> 3.18.1 Lockfile diff: lockfiles/pylint.lock [pylint] == Upgraded dependencies == setuptools 69.0.3 --> 69.2.0 Lockfile diff: lockfiles/black.lock [black] == Upgraded dependencies == platformdirs 4.1.0 --> 4.2.0 typing-extensions 4.9.0 --> 4.10.0 Lockfile diff: lockfiles/bandit.lock [bandit] == Upgraded dependencies == setuptools 69.0.3 --> 69.2.0 stevedore 5.1.0 --> 5.2.0
Visibility rules are more precise than regex, because we do not have to worry worry about false positives in comments or strings, as only actual imports and explicit dependencies count. https://www.pantsbuild.org/2.19/docs/using-pants/validating-dependencies
Fixes for this were backported to pants 2.18.3, so we can now benefit from this massive performance boost for pants.
cognifloyd
force-pushed
the
pants-upgrade
branch
from
5eb8681 to
5a975bc
Compare
pull-request-size
bot
added
size/XXL
nzlosh
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to pants 2.18 needed to wait for these which were released as part of 2.18.3:
There is a new rust-based parser for python dependency inference, but in 2.18.2 it was spewing some confusing and inaccurate warnings with our code base. pantsbuild/pants#20472 resolved those issues. We need to switch to the rust parser when we move to 2.18 or we risk a bigger transition with the move to 2.19, when the old python parser gets removed.
Now that those are merged, we get to use that new parser, and it feels much faster.