Pantsbuild: Introduce dependency rules (aka "visibility") #6133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dropping the : is very surprising https://www.pantsbuild.org/v2.16/docs/validating-dependencies#targeting-non-source-files
Visibility rules are more precise than regex, because we do not have to worry worry about false positives in comments or strings, as only actual imports and explicit dependencies count. https://www.pantsbuild.org/2.19/docs/using-pants/validating-dependencies
Once I excluded the tests files, I found that contrib/packs:metadata was inadvertently depending on the contrib/packs/tests yaml fixtures.
pull-request-size
bot
added
the
size/L
cognifloyd
force-pushed
the
pants-dep-rules
branch
from
ee71f7e to
a222988
Compare
cognifloyd
force-pushed
the
pants-dep-rules
branch
from
a222988 to
970546b
Compare
cognifloyd
force-pushed
the
pants-dep-rules
branch
from
970546b to
6e9c550
Compare
winem
approved these changes
Feb 20, 2024
nzlosh
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pants has a nifty feature that I've been looking forward to using in the st2 codebase called "visibility":
https://www.pantsbuild.org/2.19/docs/using-pants/validating-dependencies
Adding the dependency rules found an unexpected dependency from
contrib/packs/pack.yamlto the test fixtures incontrib/packs, so there's one slight change to thepack_metadatapants plugin to fix that.