Python 3.8 to 3.11 mongo 7.0 #6236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requirements and regenerate locking
… when binary not found.
…2. Use 'parser.read_file()' instead.
Contributor
Author
|
it is mostly just pytest changes.
…On Thu, Sep 12, 2024 at 22:38 Jacob Floyd ***@***.***> wrote:
I'm going to slowly review this PR. I plan to look for isolated pieces of
this PR that could go in separate PRs to make each bit of functionality
easier to review and check for completeness. I understand that breaking up
a large PR can be painful, so I'll try to minimize that pain as much as I
can.
|
guzzijones
commented
Sep 13, 2024
nzlosh
reviewed
Sep 13, 2024
cognifloyd
added a commit
that referenced
this pull request
Sep 16, 2024
This was referenced Sep 17, 2024
Member
|
Merged:
The last bits left to cherry-pick from this PR are:
|
nzlosh
approved these changes
Dec 19, 2024
Contributor
|
@guzzijones @cognifloyd Do you agree this PR can be closed now that all commits have been cherry picked and applied to master? |
Member
|
Yeah. I need to revisit adding documentation for using pants, but I can look back at a closed pr just as easily as an open one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python 3.12 works. mongodb 7.0 works.
I also fixed some unit tests.
This merges in @FileMagic and @nzlosh work on mongo 7.0.