Pants upgrade from 2.20.3 to 2.22.0 #6237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == ijson 3.1.4 --> 3.2.3 pantsbuild-pants 2.20.4 --> 2.21.1 pantsbuild-pants-testutil 2.20.4 --> 2.21.1 pex 2.2.1 --> 2.3.1
With this change, nosetest will be usable in the exported venv until we finish migrating from nosetest to pytest. By default, pex modifies script shebangs to add '-sE'. This breaks nosetest and anything that needs PYTHONPATH.
pants 2.21 makes it possible to set __defaults__ more simply because the defaults now apply to generated targets (eg a python_test target generated by a python_tests target), instead of just the targets explicitly defined in BUILD files.
Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == pantsbuild-pants 2.21.1 --> 2.22.0 pantsbuild-pants-testutil 2.21.1 --> 2.22.0
pull-request-size
bot
added
the
size/L
guzzijones
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits step through updating from 2.20 to 2.21 to 2.22.
Interesting new features in 2.21
A new
[export].py_hermetic_scriptsfeature allows us to usenosetestin the exported venv. This was added in:Note: The hermetic scripts option will be renamed to
[export].py_non_hermetic_scripts_in_resolvein 2.23:This release also allows us to simplify our
__defaults__BUILD file config. Instead of specifying(python_test, python_tests), we can just usepython_testbecause now applies to generated targets (python_testsgeneratespython_testtargets), not just the targets in BUILD files.Interesting new features in 2.22
A new
[export].py_generated_sources_in_resolveoption. I don't think we really need this now, but it makes sense to make any generated sources available in the venv (for use by an IDE like VSCode).The options system is moving to the rust-based pants engine instead of in python to speed up cli args parsing. This release only runs the new system in parallel with the old options parser in 2.22. In v2.24 (or so), pants will switch to the new options parser.
pants-plugins lockfile diffs
From 2.20 to 2.21
From 2.21 to 2.22