Packaging: Cherry-pick rpm/deb scriptlets from st2-packages #6313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from StackStorm/st2-packages@1552f46
Cherry-picked from StackStorm/st2-packages@6aa56d2
Cherry-picked from StackStorm/st2-packages@e2e71c1
Cherry-picked from StackStorm/st2-packages@c71671b
Cherry-picked from StackStorm/st2-packages@8525ddb
Cherry-picked from StackStorm/st2-packages@f2d1808
Cherry-picked from StackStorm/st2-packages@02e8868
Cherry-picked from StackStorm/st2-packages@504e740
Cherry-picked from StackStorm/st2-packages@b74e98f
… writeable access Cherry-picked from StackStorm/st2-packages@0fcda88
…(if required) Cherry-picked from StackStorm/st2-packages@a441bd7
Cherry-picked from StackStorm/st2-packages@db443c1
… and mongo do) Cherry-picked from StackStorm/st2-packages@bdd24b7
…ildren checks) Cherry-picked from StackStorm/st2-packages@e1b6489
Cherry-picked from StackStorm/st2-packages@8b844a6
…on-empty dirs such as packs) Cherry-picked from StackStorm/st2-packages@12e671a
Cherry-picked from StackStorm/st2-packages@1a16e3d
Fixes StackStorm/st2-packages#361 Cherry-picked from StackStorm/st2-packages@0dce516
Cherry-picked from StackStorm/st2-packages@e0c2f8a
Cherry-picked from StackStorm/st2-packages@e618758
Cherry-picked from StackStorm/st2-packages@21da2d8
Cherry-picked from StackStorm/st2-packages@c86c3c6
Cherry-picked from StackStorm/st2-packages@0fccf17
Cherry-picked from StackStorm/st2-packages@dae36a9
Cherry-picked from StackStorm/st2-packages@606e1d2
Cherry-picked from StackStorm/st2-packages@a2976ce
Cherry-picked from StackStorm/st2-packages@b66303e
…generators are run for socket files. Cherry-picked from StackStorm/st2-packages@7822596
Cherry-picked from StackStorm/st2-packages@3df52d0
Fixes docker build where systemctl is not available during the st2 package installation resulting in a failure. ``` Setting up st2 (3.6dev-47) ... System has not been booted with systemd as init system (PID 1). Can't operate. dpkg: error processing package st2 (--configure): installed st2 package post-installation script subprocess returned error exit status 1 ``` Cherry-picked from StackStorm/st2-packages@e6903ed
These scripts will be heavliy refactored in a follow-up PR. That refactor will also fix the shellcheck issues.
cognifloyd
requested review from
a team,
amanda11,
guzzijones,
nzlosh,
rush-skills and
winem
pull-request-size
bot
added
the
size/L
cognifloyd
commented
Mar 6, 2025
Member
Author
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
Here are links to the files in st2-packages. They should be the same including their git history.
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
nzlosh
approved these changes
Mar 7, 2025
amanda11
approved these changes
Mar 7, 2025
This was referenced Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is working towards doing packaging via pantsbuild. Eventually, I hope to archive and stop using st2-packages.git.
The post/pre install/remove scriptlets (technically only rpm uses the term scriptlets, but I'm using this term to refer to the scripts for both rpm/deb) will need to be in this repo to include them in the pants+nfpm -built rpm/deb packages. I tried to preserve the git history and git authorship, though I modified the commits I cherry-picked to only include the target scriptlets. I also excluded old irrelevant scriptlets that these commits touched, like scripts specifically for: mistral, st2resultstracker, and st2exporter. I also updated the cherry-picked commit messages to include a link to the original commit.
One of the last commits renames the scriptlets and puts them under
packaging/*/scriptsfor use by pants+nfpm. This PR does not change the contents of these files at all. In follow-up PRs, I will refactor these scripts and fix theshellcheckerrors that I've temporarily ignored.