Add test cases for timer #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It would also be good to test it "end to "end. Meaning starting a timer and making sure it actually dispatches a trigger. Besides that, LGTM, +1 |
Contributor
Author
|
Added an end to end case in a6c5301. Minimum resolution of timer seems to be 1s. |
Member
There was a problem hiding this comment.
To be on the safe side, I would also add self.assertFalse(mock_dispatcher.assert_payload()) here.
Member
|
Besides that one comment, LGTM, +1 |
lakshmi-kannan
added a commit
that referenced
this pull request
Dec 18, 2014
Add test cases for timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.