Fix st2 packs actions #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 29, 2014 22:18
* A runner param can be declared immutable in action. In this case, we can use the 'default' value supplied in either runner or action. We need default to be specified in at least one place.
* Default value for a runner param made immutable in either runner or action can also come from either.
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses problems around immutability and supplying default value for params.
If a runner param is declared immutable in runner, the default value should be supplied in runner.
If an action param is declared immutable in action, default value should be supplied in action.
If a runner param is declared immutable in action, default value can either be the one from runner or if it's supplied in action, we'll pick that up.