Skip to content

Using period instead of 'source' keyword to set up env #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mierdin merged 1 commit into from
Feb 23, 2017
Merged

Using period instead of 'source' keyword to set up env #250

Mierdin merged 1 commit into from
Feb 23, 2017

Conversation

@Mierdin
Copy link
Member

@Mierdin Mierdin commented Feb 23, 2017 •
edited
Loading

This was causing an error, because this command is running under /bin/sh, which doesn't have the "source" keyword. The dot notation should work across both sh and bash

Other tests already use this notation, but we missed this when uncommenting this test in #246, so this should rectify that

Using period instead of 'source' keyword to set up env
266ab6d 
Signed-off-by: Matt Oswalt <oswaltm@brocade.com>
bigmstone
bigmstone approved these changes Feb 23, 2017
View reviewed changes
Copy link
Contributor

@bigmstone bigmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mierdin Mierdin merged commit ee8c57c into master Feb 23, 2017
@LindsayHill LindsayHill deleted the fix/robot-mistral-tests-source branch November 2, 2018 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bigmstone bigmstone bigmstone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mierdin @bigmstone