Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Jul 12, 2018

This pull request updates release workflow to set __version__ for all the runner packages during the release process.

This change is part of StackStorm/st2#4239.

Right now this change is not backward compatible which means we need to decide how to handle backward compatibility for v2.8:

  1. Leave this code as is and cherry pick Update runner packages to read version from runner package local __init__.py file st2#4239 into v2.8 branch (should be fine)
  2. Update the workflow so setting runner version is not fatal if runner package __init__.py file doesn't contain __version__ string.

That's fine for v2.8, but I don't like it going forward (it could mask actual issues) - I prefer failing loudly where possible.

@Kami Kami changed the title Set / Bump __version__ for all the runner packages Set / bump __version__ for all the runner packages during the release Jul 12, 2018
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is think too that, cherry picking (1) sounds good enough & easiest, so we don't overcomplicate it.

@Kami
Copy link
Member Author

Kami commented Jul 13, 2018

Alright, I will make that change.

If we ever need to release patch for version < v2.8 we can make corresponding changes to this workflow.

@Kami Kami merged commit b422229 into master Jul 17, 2018
@Kami Kami deleted the also_bump_runner_versions branch July 17, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants