Skip to content

Conversation

@LizhangX
Copy link

To better support MS Teams :)
Upgrade hubot-botframework to newest code right now (01/21/20).
Note: This is NOT my work, all this PR do is to point to the newer code to this dependency.

https://github.com/microsoft/BotFramework-Hubot

Issues fixed for me from v0.10.1 (latest from MS teams from 2017)

  1. Copy paste command will shutdown chatops since the format is carried over in Teams (fixed).
  2. Channel won't respond to some messages (fixed).
  3. Line break format from the chatops response is not working (fixed).
  4. Notify action from st2 won't send back to the same command (fixed).

@LizhangX LizhangX requested a review from blag January 24, 2020 23:29
Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of pinning to a git commit, because that pretty much guarantees that we will need to bump the exact version again in the future, probably sometime soon.

As of August 27th, 2018, they do have a version 0.12.0-alpha1, it's just not pushed to NPM. Is there a way to specify a specific minimum version from a git repository?

Something like this:

"hubot-botframework": "git+https://github.com/microsoft/BotFramework-Hubot.git#^0.12.0",

If there isn't, then I'd prefer to pin to the most recent git commit, which is 01d5be9d98916243930bbe0b08be5212234fe40c as of now. Nevermind, I can't read. You have the correct git commit hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants