-
-
Notifications
You must be signed in to change notification settings - Fork 43
Update dependencies - 2nd try (security) #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The last working state after reverting failing -found 87 vulnerabilities (69 moderate, 16 high, 2 critical)
+found 131 vulnerabilities (12 low, 77 moderate, 32 high, 10 critical)which is still better than: |
nzlosh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge and see what happens.
|
ChatOps e2e tests for #133 were ✅ . |
|
e2e tests are doing good, - glad it worked. Worth mentioning that our e2e run tests against slack. There is more risk for other supported chat systems. We should ask community to check if things still work in other chat systems during the community pre-release testing. |
Second stage to update upstream dependencies #133
A follow-up to #183 which updates dependencies minimally via
npm audit fix, this PR updates things in a more radical way vianpm update.Before:
After:
This may potentially break things, so creating a dedicated PR in case if we'll need to revert it in the future (after e2e st2chatops tests).