Skip to content
This repository was archived by the owner on Sep 26, 2018. It is now read-only.

s/_sensor_service/sensor_service #497

Closed
lakshmi-kannan wants to merge 1 commit into from
Closed

s/_sensor_service/sensor_service #497

lakshmi-kannan wants to merge 1 commit into from

Conversation

@lakshmi-kannan
Copy link
Contributor

@lakshmi-kannan lakshmi-kannan commented May 19, 2016 •
edited
Loading

No description provided.

@lakshmi-kannan lakshmi-kannan mentioned this pull request May 19, 2016
Merged
@Kami
Copy link
Member

Kami commented May 19, 2016

We can't merge that until everyone upgrades to the latest version of StackStorm where this change is available.

If we merged it, it would break for everyone who is not using latest version of StackStorm (that's also the limitation because we don't have pack versioning).

Sadly we are stuck with the old approach for the foreseeable future.

@codyaray
Copy link
Contributor

codyaray commented May 19, 2016

Could you keep the inconsistent way as an alias to the correct one but mark it as deprecated and to be removed at the next major upgrade? In this case, updating all the packs in st2contrib would still be a good idea. :)

@Kami
Copy link
Member

Kami commented May 19, 2016

@codyaray Yes, that's what we are doing in the st2 PR - we will still leave the old alias there for the unforeseeable future :)

@lakshmi-kannan
Copy link
Contributor Author

lakshmi-kannan commented May 19, 2016

Yeah, I woke up this morning thinking the same. I'll close this PR.

@lakshmi-kannan lakshmi-kannan deleted the sensor_service branch May 19, 2016 23:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lakshmi-kannan @Kami @codyaray