Removing doc section that references LDAP auth backend as a future re… #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanda11
requested changes
Nov 20, 2020
Contributor
amanda11
left a comment
amanda11
left a comment
There was a problem hiding this comment.
Thanks for the contribution, this is great. Just a couple of minor comments I had.
arm4b
reviewed
Nov 20, 2020
arm4b
reviewed
Nov 20, 2020
…-auth-ldap repository documentation and parameters.
arm4b
reviewed
Nov 30, 2020
added 10 commits
November 30, 2020 13:02
…ne substitution_reference start-string without end-string.
arm4b
suggested changes
Dec 2, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Things look better, Thanks! 👍
Just left a couple more minor comments to address and we're good to merge it.
arm4b
reviewed
Dec 3, 2020
arm4b
approved these changes
Dec 3, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Looks good to me! 👍
Thanks for the documentation update for LDAP!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lease.
Closes #1035