Skip to content

Conversation

@amanda11
Copy link
Contributor

Update upgrade info with info on:

  • TLS v1.3 nginx configuration
  • st2.conf changes
  • Verification on duplicate action parameters

@amanda11 amanda11 added the bug label Jun 15, 2021
@amanda11 amanda11 added this to the 3.5.0 milestone Jun 15, 2021
@amanda11
Copy link
Contributor Author

Found as part of StackStorm/community#81

Comment on lines 196 to 201
* |st2| has been updated to configure only TLSv1.2 and v1.3 on nginx. The default nginx ST2 configuration will need to be updated manually, and nginx restarted:

.. sourcecode:: bash

sudo sed -i.bak 's|ssl_protocols.*|ssl_protocols TLSv1.2 TLSv1.3;|g' /etc/nginx/conf.d/st2.conf
sudo systemctl restart nginx
Copy link
Member

@arm4b arm4b Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW per https://github.com/StackStorm/st2-packages/blob/master/scripts/st2bootstrap-deb.sh#L633-L634
the original nginx file shipped with the packages (incl. updated 3.5.0) is located at /usr/share/doc/st2/conf/nginx/st2.conf if it would be easier to reference it instead.

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Just left a couple of optional comments.

amanda11 and others added 2 commits June 16, 2021 21:21
Updated with review comment

Co-authored-by: Eugen Cusmaunsa <stackstorm@armab.io>
@amanda11 amanda11 merged commit a55eeb4 into master Jun 16, 2021
@amanda11 amanda11 deleted the update_upgrade_notes branch June 16, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants