Skip to content

Conversation

@mamercad
Copy link
Contributor

@mamercad mamercad commented Jul 9, 2022

Fixes #1131.

@mamercad mamercad requested a review from rush-skills July 10, 2022 21:06
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the previous PR review feedback.

Added a few more comments.

@mamercad mamercad requested a review from rush-skills July 12, 2022 21:38
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the fixes!

@mamercad
Copy link
Contributor Author

LGTM!

Thanks for the fixes!

FWIW; I used this to generate the terminal screenshot, nifty app.

@arm4b
Copy link
Member

arm4b commented Jul 13, 2022

It looks cool indeed 👍

@arm4b arm4b enabled auto-merge July 13, 2022 13:18
Copy link
Member

@rush-skills rush-skills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for the contribution!

@arm4b arm4b merged commit 8c248db into StackStorm:master Jul 13, 2022
@mamercad mamercad deleted the issue-1131 branch July 13, 2022 21:02
@mamercad
Copy link
Contributor Author

It looks cool indeed 👍

Yep, makes it easy to get consistent terminal screenshots across your doc(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StackStorm HA helm install instructions

3 participants