Skip to content

Add rockylinux8 containers #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amanda11 merged 2 commits into from
Jan 18, 2022
Merged

Add rockylinux8 containers #108

amanda11 merged 2 commits into from
Jan 18, 2022

Conversation

@amanda11
Copy link
Contributor

@amanda11 amanda11 commented Jan 10, 2022 •
edited
Loading

Containers for build and test with rocky8.

Part of StackStorm/community#88

@amanda11 amanda11 added the OS support Support/issues/PRs on a specific OS label Jan 10, 2022
@amanda11 amanda11 added this to the 3.7.0 milestone Jan 10, 2022
@amanda11
Copy link
Contributor Author

amanda11 commented Jan 10, 2022

Differences to centos8:

  • Had to install procps so that st2ctl would work - so ps would work (possibly should move out of test image and into the installers?)
  • Had to install iproute - so that had utility ss - otherwise the rake test on the st2-packages would fail.

@amanda11
Copy link
Contributor Author

amanda11 commented Jan 10, 2022 •
edited
Loading

Successfully ran st2-packages using the rockylinux containers to build and test st2 rpm (st2-packages branch rocky can be used to build the RPM with containers built from this PR if anyone has need/wants to test out the RPMs on any EL8 based distros).
Keeping in draft, until managed to build st2web and st2chatops rpms and also tested to see compatabiliy of those RPMs with other EL8 distros.

stevemuskiewicz
stevemuskiewicz reviewed Jan 11, 2022
View reviewed changes
packagingbuild/rockylinux8/Dockerfile Outdated
curl \
wget

RUN yum -y install \git \
Copy link

@stevemuskiewicz stevemuskiewicz Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misplaced backslash before git?

stevemuskiewicz
stevemuskiewicz reviewed Jan 11, 2022
View reviewed changes
packagingbuild/rockylinux8/Dockerfile Outdated
RUN yum -y install \git \
mercurial \
openssh \
subversion
Copy link

@stevemuskiewicz stevemuskiewicz Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, are mercurial and subversion really still used here? 🙂

Copy link
Contributor Author

@amanda11 amanda11 Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevemuskiewicz Removed as weren't needed, and yes didn't need the \ above. Thanks for the review comments.

@amanda11 amanda11 mentioned this pull request Jan 13, 2022
Closed
16 tasks
@amanda11 amanda11 changed the title [WIP] Add rockylinux8 containers Add rockylinux8 containers Jan 14, 2022
@amanda11 amanda11 added the RFR label Jan 14, 2022
@amanda11 amanda11 requested a review from a team January 16, 2022 20:43
arm4b
arm4b approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

You'll need to build and push the new rockylinux image manually though, as Docker Hub removed the free builds.

@amanda11 amanda11 merged commit 83871d8 into master Jan 18, 2022
@amanda11 amanda11 deleted the rocky branch January 18, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stevemuskiewicz stevemuskiewicz stevemuskiewicz left review comments

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OS support Support/issues/PRs on a specific OS RFR

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@amanda11 @arm4b @stevemuskiewicz