Add tests for st2-pack-install CLI tool #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intentionally don't symlink that binary in /usr/local/bin.
running pre v2.9dev release).
arm4b
reviewed
Jul 31, 2018
| vars: | ||
| base_repo_url: "https://github.com/StackStorm" | ||
| # Note: Pack 1 should have no external dependencies beyond Python stdlib ones. | ||
| pack_to_install_1: "csv" |
Member
There was a problem hiding this comment.
Would be nice to add a version selector here (like csv=0.4.2) which will verify more complex examples alltogether, - something that was an issue in st2 PR that implemented this script.
Member
Author
There was a problem hiding this comment.
(More tests for various edge cases also wouldn't hurt of course, hopefully I can come back to that in the near future)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for the new
st2-pack-installCLI tool added in StackStorm/st2#4256.