Skip to content

Conversation

@jdmeyer3
Copy link

@jdmeyer3 jdmeyer3 commented Jun 4, 2019

This PR deals with #710 where if a form has the datatype "array of objects" it would never validate it. It also deals with the string mutation of an array of objects, causing any entered array of objects to be mutated to [object Object].

It also deals with issues from #711 where the spec may not define what kind of items an array may not have.

Closes #710
Closes #863

@jdmeyer3
Copy link
Author

jdmeyer3 commented Jun 4, 2019

@LindsayHill Is the circleci issue on my end?

#!/bin/bash -eo pipefail
PKG_VERSION=$(node -e "console.log(require('./package.json').st2_version);")
PKG_RELEASE=$(packagecloud.sh next-revision trusty ${PKG_VERSION} st2web)
echo "export PKG_VERSION=${PKG_VERSION}" >> $BASH_ENV
echo "export PKG_RELEASE=${PKG_RELEASE}" >> $BASH_ENV
/home/circleci/scripts/packagecloud.sh: line 23: PACKAGECLOUD_TOKEN:  PACKAGECLOUD_TOKEN env is required
Exited with code 1

@LindsayHill
Copy link
Contributor

Nah, that’s not on your end. Will have to see if there’s some way of handling that situation. It’s related to “who can see these private tokens - should PRs from forks be able to use them?”

@jdmeyer3
Copy link
Author

@LindsayHill Has there been any progress on the Circle CI?

@LindsayHill
Copy link
Contributor

@jdmeyer3 sorry, haven't had a chance to look at it. You should be able to run the unit tests locally, following roughly the steps up to here https://github.com/StackStorm/st2web/blob/master/.circleci/config.yml#L59

Are those passing?

@jdmeyer3 jdmeyer3 force-pushed the bug/validate_array_of_obj branch 2 times, most recently from 1fb0a0d to 460ff59 Compare September 19, 2019 16:56
@jdmeyer3 jdmeyer3 force-pushed the bug/validate_array_of_obj branch from 460ff59 to de0a3b3 Compare September 19, 2019 17:00
@jdmeyer3 jdmeyer3 changed the title WIP: Bug/validate array of obj Bug/validate array of obj Sep 19, 2019
@jdmeyer3 jdmeyer3 changed the title Bug/validate array of obj WIP: Bug/validate array of obj Sep 19, 2019
@jdmeyer3 jdmeyer3 changed the title WIP: Bug/validate array of obj Bug/validate array of obj Sep 20, 2019
@cognifloyd cognifloyd added the bug label Aug 14, 2021
Copy link
Contributor

@mickmcgrath13 mickmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test locally, but syntactically, things look good

@cognifloyd cognifloyd merged commit f97bf1a into StackStorm:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Array of type object not validating

4 participants