-
-
Notifications
You must be signed in to change notification settings - Fork 82
Bug/validate array of obj #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/validate array of obj #722
Conversation
|
@LindsayHill Is the circleci issue on my end? |
|
Nah, that’s not on your end. Will have to see if there’s some way of handling that situation. It’s related to “who can see these private tokens - should PRs from forks be able to use them?” |
|
@LindsayHill Has there been any progress on the Circle CI? |
|
@jdmeyer3 sorry, haven't had a chance to look at it. You should be able to run the unit tests locally, following roughly the steps up to here https://github.com/StackStorm/st2web/blob/master/.circleci/config.yml#L59 Are those passing? |
1fb0a0d to
460ff59
Compare
460ff59 to
de0a3b3
Compare
mickmcgrath13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not test locally, but syntactically, things look good
This PR deals with #710 where if a form has the datatype "array of objects" it would never validate it. It also deals with the string mutation of an array of objects, causing any entered array of objects to be mutated to [object Object].
It also deals with issues from #711 where the spec may not define what kind of items an array may not have.
Closes #710
Closes #863