Skip to content
This repository was archived by the owner on Aug 19, 2019. It is now read-only.

Add ca-certificates as a runtime dependency to resolve ssl issues. #131

Merged
bmoyles0117 merged 2 commits into from
Apr 5, 2018
Merged

Add ca-certificates as a runtime dependency to resolve ssl issues. #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
915fe2e
Add ca-certificates as a package dependency to resolve ssl issues.
bmoyles0117 Apr 5, 2018
342f42a
Add ca-certificates as a dependency in README.md.
bmoyles0117 Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ This is the Stackdriver metadata agent.

$ sudo apt-get install libssl1.0.0 libyajl2 libboost-filesystem1.58.0 \
libboost-program-options1.58.0 libboost-system1.58.0 \
libboost-thread1.58.0
libboost-thread1.58.0 ca-certificates

2. Install build dependencies:

Expand All @@ -42,7 +42,7 @@ This is the Stackdriver metadata agent.

$ sudo apt-get install libssl1.0.2 libyajl2 libboost-filesystem1.62.0 \
libboost-program-options1.62.0 libboost-system1.62.0 \
libboost-thread1.62.0
libboost-thread1.62.0 ca-certificates
Copy link
Contributor

@dhrupadb dhrupadb Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a build dependency because it needs the certs to be present just at runtime. Unless we are specifying that runtime dependencies must be a subset of build dependencies.

Copy link
Contributor

@dhrupadb dhrupadb Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm github diff being silly. LGTM


2. Install build dependencies:

Expand Down
2 changes: 1 addition & 1 deletion pkg/deb/debian/control.base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Build-Depends: g++, cmake, dpkg-dev, libyajl-dev (>= 2.0), libssl-dev, libboost1

Package: stackdriver-metadata
Architecture: amd64
Depends: libyajl2, libboost-filesystem1.55.0, libboost-program-options1.55.0, libboost-system1.55.0, libboost-thread1.55.0
Depends: libyajl2, libboost-filesystem1.55.0, libboost-program-options1.55.0, libboost-system1.55.0, libboost-thread1.55.0, ca-certificates
Copy link
Contributor

@supriyagarg supriyagarg Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the readme to include this new dependency

Copy link
Contributor Author

@bmoyles0117 bmoyles0117 Apr 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Description: Stackdriver metadata collection daemon
The Stackdriver metadata daemon collects resource metadata and
sends it to the Stackdriver service.