Skip to content
This repository was archived by the owner on Aug 19, 2019. It is now read-only.

Conversation

@igorpeshansky
Copy link
Contributor

No description provided.

Copy link
Contributor

@bmoyles0117 bmoyles0117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@davidbtucker davidbtucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidbtucker
Copy link
Contributor

davidbtucker commented May 16, 2018

Also, should we update README.md to say brew install openssl?

@davidbtucker
Copy link
Contributor

davidbtucker commented May 16, 2018

One more thing: Update test/Makefile with the same flags.

@igorpeshansky
Copy link
Contributor Author

Done both things requested by @davidbtucker. PTAL.

README.md Outdated
1. Install runtime dependencies:

$ brew install boost -c++11 && \
*Note: this currently does not works with boost@1.67, which is the latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/works/work/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, done (it used to be "this only works", and didn't get inverted correctly).

Copy link
Contributor

@davidbtucker davidbtucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpeshansky igorpeshansky merged commit 5746c23 into master May 21, 2018
@igorpeshansky igorpeshansky deleted the igorp-macos-support branch May 21, 2018 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants